Changeset 549 for trunk/grails-app/services/InventoryItemService.groovy

Timestamp:

May 27, 2010, 9:24:43 PM (15 years ago)

Author:

gav

Message:

Add InventoryItemService savePicture(), part 2.
Add some more comments, another error code and ensure the inputStream gets closed.
Add gnuMims logo as an example picture to the demo inventory items.

File:

• trunk/grails-app/services/InventoryItemService.groovy (modified) (4 diffs)

trunk/grails-app/services/InventoryItemService.groovy

@@ -261 +261 @@
                 return fail(field:"picture", code:"inventory.item.already.has.picture")
 
+            // Declare some more variables, since we appear to have most of what we need.
             def picture = new Picture(inventoryItem: result.inventoryItemInstance)
             def imaging = new Imaging()
@@ -268 +269 @@
             def pictureInputStream
 
+            // Check the supplied pictureSource and get the inputStream.
             if(pictureSource instanceof javax.servlet.http.HttpServletRequest) {
                 def multiPartFile = pictureSource.getFile('file')
@@ -293 +295 @@
             }
             else {
-                    return fail(code:"default.file.not.supplied")
-            }
-
+                    return fail(code:"inventory.item.picture.source.not.supported")
+            }
+
+            // Create the Images.
             try {
                 images = imaging.createAll(result.inventoryItemInstance, picture, pictureInputStream)
+                // Ensure the stream is closed.
+                pictureInputStream.close()
             }
             catch(Exception ex) {
                 log.error("picture save", ex)
+                // Ensure the stream is closed.
+                pictureInputStream.close()
                 return fail(code:"inventory.item.picture.file.unrecognised", args: [pictureFileName])
             }
 
+            // Add images to picture.
             images.each { image ->
                 picture.addToImages(image)
             }
 
+            // Save picture.
             if(picture.hasErrors() || !picture.save())
                 return fail(code:"default.create.failure", args: ["Picture"])
@@ -313 +322 @@
             result.inventoryItemInstance.picture = picture
 
+            // Save inventoryItem.
             if(result.inventoryItemInstance.hasErrors() || !result.inventoryItemInstance.save())
                 return fail(code:"default.create.failure")