Changeset 425

Timestamp:

Mar 3, 2010, 3:50:21 PM (14 years ago)

Author:

gav

Message:

Handle InventoryItem reverse alternateItems.

Location:

trunk/grails-app

Files:

• controllers/InventoryItemDetailedController.groovy (modified) (2 diffs)
• domain/InventoryItem.groovy (modified) (1 diff)
• i18n/messages.properties (modified) (1 diff)
• services/InventoryItemService.groovy (modified) (4 diffs)
• views/inventoryItemDetailed/edit.gsp (modified) (1 diff)
• views/inventoryItemDetailed/show.gsp (modified) (1 diff)

trunk/grails-app/controllers/InventoryItemDetailedController.groovy

@@ -238 +238 @@
         def result = inventoryItemService.edit(params)
 
-        if(!result.error)
-            return [ inventoryItemInstance : result.inventoryItemInstance ]
+        if(!result.error) {
+            def possibleAlternateItems = inventoryItemService.getPossibleAlternateItems(result.inventoryItemInstance)
+            return [ inventoryItemInstance : result.inventoryItemInstance, possibleAlternateItems: possibleAlternateItems]
+        }
 
         flash.errorMessage = g.message(code: result.error.code, args: result.error.args)
@@ -260 +262 @@
         }
 
-        render(view:'edit', model:[inventoryItemInstance: result.inventoryItemInstance.attach()])
+        def possibleAlternateItems = inventoryItemService.getPossibleAlternateItems(result.inventoryItemInstance)
+        render(view:'edit', model:[inventoryItemInstance: result.inventoryItemInstance.attach(), possibleAlternateItems: possibleAlternateItems])
     }
 

trunk/grails-app/domain/InventoryItem.groovy

@@ -56 +56 @@
 
     String toString() {"${this.name}"}
+
+    def afterInsert = {
+        addReverseAlternateItems()
+    }
+
+    // Add reverse alternateItem references.
+    def addReverseAlternateItems() {
+        this.alternateItems.each() {
+            if( !it.alternateItems?.contains(this) )
+                it.addToAlternateItems(this)
+        }
+    }
+
+    /**
+   * Remove all reverse alternateItem references.
+    * Update: reverse alternateItem handling must be done in the
+    * service class since the before assignment alternateItems are required.
+    */
+    def removeReverseAlternateItems(alternateItems = this.alternateItems) {
+        alternateItems.each() {
+            it.removeFromAlternateItems(this)
+        }
+    }
+
 }

trunk/grails-app/i18n/messages.properties

@@ -123 +123 @@
 inventoryMovement.quantity.insufficientItemsInStock=Could not complete operation, insufficient items in stock.
 inventoryMovement.inventoryItem.notFound=Inventory Item not found.
+inventoryMovement.still.associated=Could not complete operation as inventory movements are still associated with this item.
 
 assignedGroup.task.not.found=Please select a task and then ''Add Assigned Group''.

trunk/grails-app/services/InventoryItemService.groovy

@@ -5 +5 @@
 
     boolean transactional = false
+
+    /**
+    * Prepare a sorted list of possible alternateItems.
+    */
+    def getPossibleAlternateItems(inventoryItemInstance) {
+        def criteria = inventoryItemInstance.createCriteria()
+        def possibleAlternateItems = criteria {
+            and {
+                eq('isActive', true)
+                notEqual('id', inventoryItemInstance.id)
+            }
+        }.sort { p1, p2 -> p1.name.compareToIgnoreCase(p2.name) }
+    }
 
     /**
@@ -50 +63 @@
 
     def delete(params) {
-        def result = [:]
-        def fail = { Map m ->
-            result.error = [ code: m.code, args: ["InventoryItem", params.id] ]
-            return result
-        }
+        InventoryItem.withTransaction { status ->
+            def result = [:]
 
-        result.inventoryItemInstance = InventoryItem.get(params.id)
+            def fail = { Map m ->
+                status.setRollbackOnly()
+                if(result.inventoryItemInstance && m.field)
+                    result.inventoryItemInstance.errors.rejectValue(m.field, m.code)
+                result.error = [ code: m.code, args: ["InventoryItem", params.id] ]
+                return result
+            }
 
-        if(!result.inventoryItemInstance)
-            return fail(code:"default.not.found")
+            result.inventoryItemInstance = InventoryItem.get(params.id)
 
-        try {
-            result.inventoryItemInstance.delete(flush:true)
-            return result //Success.
-        }
-        catch(org.springframework.dao.DataIntegrityViolationException e) {
-            return fail(code:"default.delete.failure")
-        }
+            if(!result.inventoryItemInstance)
+                return fail(code:"default.not.found")
 
-    }
+            if(result.inventoryItemInstance.inventoryMovements)
+                return fail(code:"inventoryMovement.still.associated")
+
+            result.inventoryItemInstance.removeReverseAlternateItems()
+
+            try {
+                result.inventoryItemInstance.delete(flush:true)
+                return result //Success.
+            }
+            catch(org.springframework.dao.DataIntegrityViolationException e) {
+                return fail(code:"default.delete.failure")
+            }
+
+        } //end withTransaction
+    } // end delete()
 
     def edit(params) {
@@ -110 +134 @@
             }
 
+            def previousAlternateItems = new ArrayList(result.inventoryItemInstance.alternateItems)
+
             result.inventoryItemInstance.properties = params
 
             if(result.inventoryItemInstance.hasErrors() || !result.inventoryItemInstance.save())
                 return fail(code:"default.update.failure")
+
+            result.inventoryItemInstance.removeReverseAlternateItems(previousAlternateItems)
+            result.inventoryItemInstance.addReverseAlternateItems()
 
             // Success.
@@ -158 +187 @@
     }
 
-
 } // end class

trunk/grails-app/views/inventoryItemDetailed/edit.gsp

@@ -238 +238 @@
                                 <td valign="top" class="value ${hasErrors(bean:inventoryItemInstance,field:'alternateItems','errors')}">
                                     <g:select name="alternateItems"
-                                                        from="${ InventoryItem.list().sort { p1, p2 -> p1.name.compareToIgnoreCase(p2.name) } }"
+                                                        from="${possibleAlternateItems}"
                                                         size="5" multiple="yes" optionKey="id"
                                                         value="${inventoryItemInstance?.alternateItems.id}" noSelection="['':'--None--']"/>

trunk/grails-app/views/inventoryItemDetailed/show.gsp

@@ -149 +149 @@
                                         <td  valign="top" style="text-align:left;" class="value">
                                             <ul>
-                                            <g:each var="a" in="${inventoryItemInstance.alternateItems}">
+                                            <g:each var="a" in="${ inventoryItemInstance.alternateItems.sort { p1, p2 -> p1.name.compareToIgnoreCase(p2.name) } }">
                                                 <li><g:link controller="inventoryItemDetailed" action="show" id="${a.id}">${a?.encodeAsHTML()}</g:link></li>
                                             </g:each>